Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: use webengine i/o webkit #92118

Merged
merged 1 commit into from Jul 4, 2020
Merged

calibre: use webengine i/o webkit #92118

merged 1 commit into from Jul 4, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

As of v4, calibre supports qtwebengine so use that instead of the
deprecated qtwebkit.

This way we don't have to compile qtwebkit locally which is a PITA.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
calibre: use webengine i/o webkit
1da9cd8 
As of v4, calibre supports qtwebengine so use that instead of the
deprecated qtwebkit.
@veprbl veprbl mentioned this pull request Jul 3, 2020
Closed
69 tasks
@veprbl
Copy link
Member

veprbl commented Jul 3, 2020

Thanks. I missed that one when reviewing 16fe603

@peterhoeg peterhoeg merged commit 770faa0 into master Jul 4, 2020
@peterhoeg peterhoeg deleted the f/calibre branch July 4, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@pSub pSub Awaiting requested review from pSub

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @veprbl