Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/g810-led: init #92124

Closed
wants to merge 1 commit into from
Closed

nixos/g810-led: init #92124

wants to merge 1 commit into from

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Jul 3, 2020 •
edited

Motivation for this change

Add g810-led module. This module allows for setting a custom color profile via nixos configuration.

g810-led is an LED controller for Logitech keyboards and can be used to set custom colors for any keys and also supports multiple animated effects.

Things done

Built and tested with Logitech G910.

Depends on #92119

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samuelgrf samuelgrf mentioned this pull request Jul 3, 2020
Closed
10 tasks
@samuelgrf
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Sep 9, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 9, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@samuelgrf
Copy link
Member Author

samuelgrf commented Sep 9, 2020 •
edited

Sorry, wrong status, as this still depends on #92119 being merged.
/status awaiting_changes

@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
@samuelgrf
Copy link
Member Author

Closing because I am not using the module anymore and don't have the time to maintain it.

To save anyone who wants to pick up this PR some debugging:
When plugging a keyboard into a USB hub there's an issue caused by the udev rules using SUBSYSTEMS=="usb" for detecting the keyboard and causes it to flicker for a few seconds after plugging it in.

AFAIK this should be fixable by simply removing the lines.

@samuelgrf samuelgrf closed this Mar 29, 2021
@samuelgrf
Copy link
Member Author

/marvin opt-out

@samuelgrf samuelgrf mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samuelgrf