Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.awkward1: 0.2.23 -> 0.2.24 #92123

Merged
merged 1 commit into from Jul 4, 2020
Merged

python3Packages.awkward1: 0.2.23 -> 0.2.24 #92123

merged 1 commit into from Jul 4, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 3, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Jul 3, 2020

Targeting staging as the awkward1 0.2.24 requires numba 0.50

@veprbl veprbl added this to WIP in Staging via automation Jul 3, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Jul 3, 2020
jonringer
jonringer approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92123 1

2 packages built: - python37Packages.awkward1 - python38Packages.awkward1

Staging automation moved this from Needs review to Ready Jul 4, 2020
@jonringer jonringer merged commit f02d1db into NixOS:staging Jul 4, 2020
Staging automation moved this from Ready to Done Jul 4, 2020
@veprbl veprbl deleted the pr/awkward1_0_2_24 branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @jonringer