Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.15.1 -> 1.15.2 [security] #92098

Merged
merged 1 commit into from Jul 2, 2020
Merged

matrix-synapse: 1.15.1 -> 1.15.2 [security] #92098

merged 1 commit into from Jul 2, 2020

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Jul 2, 2020 •
edited by Ma27

Motivation for this change

Security release, see https://github.com/matrix-org/synapse/blob/release-v1.15.2/CHANGES.md#synapse-1152-2020-07-02

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan tokudan requested a review from Ma27 July 2, 2020 22:19
@tokudan
Copy link
Contributor Author

tokudan commented Jul 2, 2020

@GrahamcOfBorg test matrix-synapse

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 2, 2020
@tokudan tokudan mentioned this pull request Jul 2, 2020
Merged
10 tasks
@tokudan
Copy link
Contributor Author

tokudan commented Jul 2, 2020

port to stable in #92101

Ma27
Ma27 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and deployed to my personal HS. Thanks!

@Ma27 Ma27 merged commit d8ee55c into NixOS:master Jul 2, 2020
@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@pacien pacien Awaiting requested review from pacien

@fadenb fadenb Awaiting requested review from fadenb

@Ralith Ralith Awaiting requested review from Ralith

@Ekleog Ekleog Awaiting requested review from Ekleog

@mguentner mguentner Awaiting requested review from mguentner

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokudan @Ma27 @mmilata