New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python2Packages: don't recurseIntoAttrs #92099
Conversation
As long as there are users that are willing to put in the effort to keep these packages working, I think we should keep building them. The set is already smaller than it was and will only get smaller over time as well. Security issues are something people can choose for themselves whether they consider it an issue or not. We should just avoid having any thing else depend on these packages. Two years ago i ran a poll to ask what package sets people were interested in https://discourse.nixos.org/t/python-packages-what-versions-to-build-on-hydra/1243. Note multiple options were possible. Run it again and see what people answer. Hopefully there would be actual replies to it as well. I spoke earlier with @adisbladis and @grahamc and we think we can have a Python 2 "overlay", so people don't need to bother with |
overlay seems fine, but it is getting annoying that |
Right, so what I was thinking is you get something like
The disables for Python 2 would then move into the python 2 overlay. Heck, we could even decide that it does not depend on the python3 packages set at all. |
To be clear, I also do not want to spend much time on this, this is really something Python 2 users in the end need to maintain. |
For applications which use python2, some of the package set will still be built. The major changes is that not all of the python2 packages will be built. I'm not a fan of spending much time to extend python2's usage, which is why I opened this PR :). So I don't see python2 packages when doing |
closing as this won't likely happen |
@FRidh maybe we do this after 20.09 branch off? |
We should probably by then create a separate |
hmm, maybe, but just bring over the commonly used packages like |
Yes. I don't know how many packages are still Python 2 compatible. Frankly, I am also thinking of just skipping it. Those that want Python 2 packages should take the initiative and do the work, but that's not really happening. |
Let's merge this otherwise after branch-off. If people complain they can go and fix it themselves. |
most of distro's are just dropping python2 specific applications, I think we should follow suit given the security implications and maintenance burden |
Motivation for this change
felt like this is overdue. Python has been EOL for >5 months now, also has active CVEs. This isn't to kill the package set, but rather not have hydra build the packages, and
nixpkgs-review
will no longer test python2 packages for breakages.https://discourse.nixos.org/t/what-should-i-expect-to-find-in-cache-nixos-org/7935/5
cc @FRidh
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)