Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: documentation outputs #92128

Merged
merged 3 commits into from Jul 19, 2020
Merged

wayland: documentation outputs #92128

merged 3 commits into from Jul 19, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 3, 2020

Motivation for this change

Build the documentation by default, but install it to seperate outputs
so it doesn't have to be downloaded. Documentation is still disabled
when cross-compiling, because that is currently broken:
wayland -> graphviz -> libdevil -> openexr -> ilmbase (broken)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
automake115x: 1.15 -> 1.15.1
57f3c83
@alyssais
gd: fix "Error: Problem doing text layout"
10ad3f6 
This backport allows the Wayland documentation to be successfully
built.
@alyssais alyssais changed the title Wayland doc wayland: documentation outputs Jul 3, 2020
@alyssais
wayland: documentation outputs
ee5f705 
Build the documentation by default, but install it to seperate outputs
so it doesn't have to be downloaded.  Documentation is still disabled
when cross-compiling, because that is currently broken:
wayland -> graphviz -> libdevil -> openexr -> ilmbase (broken)
@ofborg ofborg bot requested review from codyopel and primeos July 4, 2020 12:32
vcunat
vcunat approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@vcunat vcunat merged commit 956f322 into NixOS:staging Jul 19, 2020
@alyssais alyssais mentioned this pull request Oct 29, 2020
Merged
10 tasks
@alyssais alyssais deleted the wayland-doc branch April 9, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@codyopel codyopel Awaiting requested review from codyopel

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @vcunat