Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_15: 1.15beta1 -> 1.15 #95235

Merged
merged 1 commit into from Aug 21, 2020
Merged

go_1_15: 1.15beta1 -> 1.15 #95235

merged 1 commit into from Aug 21, 2020

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Aug 12, 2020

Actions taken:
ssl patch removed ARM section, file no longer exists
bump source version and hash

Motivation for this change

https://golang.org/doc/go1.15

Things done

Modified patch to remove failure. File no longer exists. Needs additional testing on other architectures.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS - x86 only (EDIT: + armv7l)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 12, 2020

ssl patch removed ARM section, file no longer exists

It was renamed to root_darwin_ios.go.

@zowoq zowoq changed the title go: 1_15beta1 -> 1_15 go: 1.15beta1 -> 1.15 Aug 12, 2020
@cryptix
Copy link
Contributor

cryptix commented Aug 12, 2020

Tested and works for me!

@Mic92
Copy link
Member

Mic92 commented Aug 12, 2020

@GrahamcOfBorg build direnv

@zowoq
Copy link
Contributor

zowoq commented Aug 12, 2020

... build direnv

buildGo{Module,Package} is still on go_1_14.

@problame
Copy link

problame commented Aug 12, 2020

I had a Go test suite test failure on Fedora 31:

--- FAIL: TestChown (0.00s)
    os_unix_test.go:58: gid: 100
    os_unix_test.go:70: groups:  [65534 100]
    os_unix_test.go:73: chown /tmp/_Go_TestChown273750579 -1 65534: chown /tmp/_Go_TestChown273750579: invalid argument
--- FAIL: TestFileChown (0.00s)
    os_unix_test.go:101: gid: 100
    os_unix_test.go:113: groups:  [65534 100]
    os_unix_test.go:116: fchown /tmp/_Go_TestFileChown026046966 -1 65534: chown /tmp/_Go_TestFileChown026046966: invalid argument
--- FAIL: TestLchown (0.00s)
    os_unix_test.go:153: gid: 100
    os_unix_test.go:168: groups:  [65534 100]
    os_unix_test.go:171: lchown /tmp/_Go_TestLchown1881673892 -1 65534: lchown /tmp/_Go_TestLchown1881673892: invalid argument
FAIL
FAIL    os      0.655s

UPDATE: dmesg doesn't show any errors wrt to the presumed EINVAL syscall return value.

@tomberek
Copy link
Contributor Author

@problame I encountered a similar thing on armv7l. The distinction seemed to be sandbox vs no-sandbox

armv7l builds and seems to function.

Should we keep/remove the procps dependency? Removing it on linux doesn't seem to break tests and removes lots of dependencies from the build closure.

@zowoq
Copy link
Contributor

zowoq commented Aug 13, 2020

@ofborg build go_1_15

@zowoq zowoq changed the title go: 1.15beta1 -> 1.15 go_1_15: 1.15beta1 -> 1.15 Aug 13, 2020
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert
Copy link
Member

@zowoq I'm wondering what the state of this is. Which builds do not work right now?

Can we still move forward without setting go1.15 as the default? go1.14 had a regression and projects like Kubernetes now require 1.15…

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

Can we still move forward without setting go1.15 as the default?

Yes, we can merge this and switch the default in another PR.

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

@ofborg build go_1_15

Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked darwin build.

@zowoq zowoq merged commit a3b69f4 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants