New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_1_15: 1.15beta1 -> 1.15 #95235
go_1_15: 1.15beta1 -> 1.15 #95235
Conversation
It was renamed to |
Tested and works for me! |
@GrahamcOfBorg build direnv |
|
I had a Go test suite test failure on Fedora 31:
UPDATE: |
@problame I encountered a similar thing on armv7l. The distinction seemed to be sandbox vs no-sandbox armv7l builds and seems to function. Should we keep/remove the procps dependency? Removing it on linux doesn't seem to break tests and removes lots of dependencies from the build closure. |
@ofborg build go_1_15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zowoq I'm wondering what the state of this is. Which builds do not work right now? Can we still move forward without setting go1.15 as the default? go1.14 had a regression and projects like Kubernetes now require 1.15… |
Yes, we can merge this and switch the default in another PR. |
@ofborg build go_1_15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked darwin build.
Actions taken:
ssl patch removed ARM section, file no longer exists
bump source version and hash
Motivation for this change
https://golang.org/doc/go1.15
Things done
Modified patch to remove failure. File no longer exists. Needs additional testing on other architectures.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)