Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobetween, kustomize: remove deleteVendor, enable checks #95247

Merged
merged 2 commits into from Aug 12, 2020
Merged

gobetween, kustomize: remove deleteVendor, enable checks #95247

merged 2 commits into from Aug 12, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 12, 2020 •
edited

Neither of these have a vendor directory to delete so deleteVendor is a no op.

@zowoq zowoq mentioned this pull request Aug 12, 2020
Merged
vdemeester
vdemeester approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@flokli flokli merged commit 38c6c46 into NixOS:master Aug 12, 2020
@zowoq zowoq deleted the deletevendor-check branch August 12, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@zaninime zaninime zaninime approved these changes

@tomberek tomberek Awaiting requested review from tomberek

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@kalbasit kalbasit Awaiting requested review from kalbasit

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @vdemeester @zaninime @flokli