Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darktable: 3.0.2 -> 3.2.1 #95240

Merged
merged 1 commit into from Aug 12, 2020
Merged

darktable: 3.0.2 -> 3.2.1 #95240

merged 1 commit into from Aug 12, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 12, 2020

Motivation for this change

Release information: https://www.darktable.org/2020/08/darktable-3-2/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine.

Result of nixpkgs-review pr 95240 1

1 package built:
- darktable

Did database migration work well for you? After the migration, I didn't see any photos in darktable. After re-adding a folder it seems to import things correctly (with star ratings and all).

@lsix
Copy link
Member Author

lsix commented Aug 12, 2020

@danieldk yes, after launching darktable and allowing it to upgrade the database, I had my collections still there.

@danieldk
Copy link
Contributor

@danieldk yes, after launching darktable and allowing it to upgrade the database, I had my collections still there.

Ack, probably something odd in my setup.

@danieldk danieldk merged commit 66dd4f3 into NixOS:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@flosse flosse Awaiting requested review from flosse

@mrVanDalo mrVanDalo Awaiting requested review from mrVanDalo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsix @danieldk