Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: 5.0.0 -> 5.1.0 #95252

Merged
merged 1 commit into from Aug 16, 2020
Merged

qemu: 5.0.0 -> 5.1.0 #95252

merged 1 commit into from Aug 16, 2020

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Aug 12, 2020 •
edited

Motivation for this change

https://wiki.qemu.org/ChangeLog/5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@misuzu misuzu changed the base branch from staging to master August 12, 2020 12:08
@alyssais
Copy link
Member

@GrahamcOfBorg test boot

@alyssais
Copy link
Member

@misuzu you beat me to it by 15 minutes! :D

I see this is marked as a draft — is there anything you still want to before it’s ready?

@alyssais
Copy link
Member

@GrahamcOfBorg build qemu

@misuzu
Copy link
Contributor Author

misuzu commented Aug 12, 2020

@misuzu you beat me to it by 15 minutes! :D

I see this is marked as a draft — is there anything you still want to before it’s ready?

Just wanted to make sure it works on x86-64. Had no issues on aarch64.

@misuzu misuzu marked this pull request as ready for review August 12, 2020 12:21
@ofborg ofborg bot requested a review from edolstra August 12, 2020 12:31
@alyssais
Copy link
Member

alyssais commented Aug 12, 2020 via email

alevy
alevy approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@alevy alevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested today on NixOS and works for me

@misuzu misuzu requested review from tfc and blitz August 15, 2020 08:45
@alyssais alyssais merged commit 2402867 into NixOS:master Aug 16, 2020
@misuzu misuzu deleted the qemu-update branch April 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevy alevy alevy approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@tfc tfc Awaiting requested review from tfc

@blitz blitz Awaiting requested review from blitz

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misuzu @alyssais @alevy