Test RemoteStore::buildDerivation
#3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
commented
Aug 12, 2020
| chmod -R u+w $TEST_ROOT/machine1 || true | ||
| chmod -R u+w $TEST_ROOT/machine2 || true | ||
| rm -rf $TEST_ROOT/machine0 $TEST_ROOT/machine1 $TEST_ROOT/machine2 | ||
| rm -f $TEST_ROOT/result |
There was a problem hiding this comment.
We now run init.sh before every test so we don't need this.
Ericson2314
commented
Aug 12, 2020
tests/build-remote.sh
Outdated
| builders=( | ||
| "ssh://localhost?remote-store=$TEST_ROOT/machine1" | ||
| "$TEST_ROOT/machine2 - - 1 1 foo" | ||
| "ssh-ng://localhost?remote-store=$TEST_ROOT/machine3?systemFeatures=baz - - 1 1 baz" |
There was a problem hiding this comment.
?systemFeatures=baz won't work, but it's failing before it even gets that far.
Before, processConnection wanted to know a user name and user id, and `nix-daemon --stdio`, when it isn't proxying to an underlying daemon, would just assume "root" and 0. But `nix-daemon --stdio` (no proxying) shouldn't make guesses about who holds the other end of its standard streams. Now processConnection takes an "auth hook", so `nix-daemon` can provide the appropriate policy and daemon.cc doesn't need to know or care what it is.
Ericson2314
force-pushed
the
test-RemoteStore-buildDerivation
branch
from
745419d
to
877a1b7
Compare
This seems more correct. It also means one can specify the features a store should support with --store and remote-store=..., which is useful. I use this to clean up the build remotes test.
Ericson2314
force-pushed
the
test-RemoteStore-buildDerivation
branch
from
877a1b7
to
5d62fb1
Compare
Ericson2314
changed the title
RemoteStore::buildDerivationRemoteStore::buildDerivation -- contains #3923 & #3924
Fix `wopNarFromPath` which needed a `toRealPath`.
Ericson2314
force-pushed
the
test-RemoteStore-buildDerivation
branch
from
5d62fb1
to
d2f2be0
Compare
Ericson2314
changed the title
RemoteStore::buildDerivation -- contains #3923 & #3924RemoteStore::buildDerivation -- contains #3923 & #3924
Ericson2314
changed the title
RemoteStore::buildDerivation -- contains #3923 & #3924RemoteStore::buildDerivation -- contains #3924
edolstra
reviewed
Aug 14, 2020
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Ericson2314
changed the title
RemoteStore::buildDerivation -- contains #3924RemoteStore::buildDerivation
|
Oh good, still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
wopNarFromPathwhich needed atoRealPath.