buildGoModule: update deleteVendor docs #95246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
commented
Aug 12, 2020
| @@ -85,7 +85,12 @@ let | |||
| runHook preBuild | |||
|
|
|||
| if [ ${deleteFlag} == "true" ]; then | |||
| rm -rf vendor | |||
| if [ ! -e vendor ]; then | |||
| echo "vendor folder does not exist, 'deleteVendor' is not needed" | |||
There was a problem hiding this comment.
2/4 packages using deleteVendor don't have a vendor folder to delete. #95247
Mic92
approved these changes
Aug 12, 2020
Mic92
reviewed
Aug 12, 2020
kalbasit
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen some confusion about when
deleteVendorshould be used, we don't explain that is is for when the vendor folder is broken or incomplete and thatvendorSha256 = nullis preferred.Simplifying the message and listing the less common options in the docs should be fine.