Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: disable flaky test "udp_multicast_join" on darwin #93911

Merged
merged 1 commit into from Jul 26, 2020
Merged

libuv: disable flaky test "udp_multicast_join" on darwin #93911

merged 1 commit into from Jul 26, 2020

Conversation

thefloweringash
Copy link
Member

Motivation for this change

I'm working on changes to the darwin stdenv on a headless Catalina machine and this test always fails.

There's been some previous work by @basvandijk at libuv/libuv#2675 (comment), and #79381 but the resolution there didn't include this test and the discussion didn't mention it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 26, 2020
@ofborg ofborg bot requested a review from cstrahan July 26, 2020 13:03
vcunat
vcunat approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. It would be nice to understand why, but the cost/benefits ratio...

@FRidh FRidh merged commit 2d6b1f1 into NixOS:staging Jul 26, 2020
@thefloweringash thefloweringash deleted the libuv-tests branch July 26, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @vcunat @FRidh