Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddgr: 1.8.1 -> 1.9 #93928

Merged
merged 1 commit into from Jul 28, 2020
Merged

ddgr: 1.8.1 -> 1.9 #93928

merged 1 commit into from Jul 28, 2020

Conversation

markus1189
Copy link
Contributor

Changelog: https://github.com/jarun/ddgr/releases/tag/v1.9

Fixes current breakage due to API changes.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189
ddgr: 1.8.1 -> 1.9
abc7e5a 
Changelog: https://github.com/jarun/ddgr/releases/tag/v1.9

Fixes current breakage due to API changes.
@markus1189 markus1189 marked this pull request as ready for review July 26, 2020 16:53
@ofborg ofborg bot requested a review from ceedubs July 26, 2020 17:01
ceedubs
ceedubs approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! I tested the binary locally on darwin and it worked for me.

tomberek
tomberek approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions as expected on NixOS.

@marsam marsam merged commit 75409cc into NixOS:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@ceedubs ceedubs ceedubs approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markus1189 @tomberek @ceedubs @marsam