Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.xpadneo: 0.8.1 -> 0.8.2 #93847

Merged
merged 1 commit into from Aug 3, 2020

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jul 25, 2020

Also fixes kernel module version: @DO_NOT_CHANGE@ -> 0.8.2

Motivation for this change

Upgrade to the latest release: https://github.com/atar-axis/xpadneo/releases/tag/v0.8.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

    No binary files. Enabled with hardware.xpadneo.enable = true & tested through use of Xbox One controller.

    Tested:

    • Bluetooth connectivity
    • All buttons
    • Rumble support

    > modinfo hid_xpadneo
    filename:       /run/current-system/kernel-modules/lib/modules/5.7.9/extra/hid-xpadneo.ko.xz
    version:        0.8.2
    description:    Linux kernel driver for Xbox ONE S+ gamepads (BT), incl. FF
    author:         Florian Dollinger <dollinger.florian@gmx.de>
    license:        GPL
    srcversion:     3D77A9FCE33246E56A7AE59
    alias:          hid:b0005g*v0000045Ep00000B05
    alias:          hid:b0005g*v0000045Ep000002E0
    alias:          hid:b0005g*v0000045Ep000002FD
    depends:        hid,ff-memless
    retpoline:      Y
    name:           hid_xpadneo
    vermagic:       5.7.9 SMP mod_unload
    parm:           debug_level:(u8) Debug information level: 0 (none) to 3+ (most verbose). (byte)
    parm:           combined_z_axis:(bool) Combine the triggers to form a single axis. 1: combine, 0: do not combine. (bool)
    parm:           trigger_rumble_mode:(u8) Trigger rumble mode. 0: pressure, 1: directional, 2: disable. (byte)
    parm:           rumble_attenuation:(u8) Attenuate the rumble strength: all[,triggers] 0 (none, full rumble) to 100 (max, no rumble). (array of byte)
    parm:           ff_connect_notify:(bool) Connection notification using force feedback. 1: enable, 0: disable. (bool)
    parm:           gamepad_compliance:(bool) Adhere to Linux Gamepad Specification by using signed axis values. 1: enable, 0: disable. (bool)
    parm:           quirks:array of charp
    parm:           quriks:(string) Override device quirks, specify as: "MAC1:quirks1[,...16]", MAC format = 11:22:33:44:55:66, no pulse parameters = 1, no trigger rumble = 2, no motor masking = 4
    
  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@kira-bruneau kira-bruneau changed the title nixos/xpadneo: 0.8.1 -> 0.8.2 xpadneo: 0.8.1 -> 0.8.2 Aug 3, 2020
@worldofpeace
Copy link
Contributor

@ofborg build xpadneo

@worldofpeace
Copy link
Contributor

@ofborg build linuxPackages.xpadneo linuxPackages_latest.xpadneo

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change attribute in commit message to linuxPackages.xpadneo

Also fixes kernel module version: @DO_NOT_CHANGE@ -> 0.8.2
@kira-bruneau kira-bruneau changed the title xpadneo: 0.8.1 -> 0.8.2 linuxPackages.xpadneo: 0.8.1 -> 0.8.2 Aug 3, 2020
@worldofpeace worldofpeace merged commit 29fc5af into NixOS:master Aug 3, 2020
@kira-bruneau
Copy link
Contributor Author

@worldofpeace Thanks again! 😄

Would it be ok if I continued adding you to future updates? It seemed like the PR was going stale without a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants