Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: fix build #93849

Merged
merged 1 commit into from Jul 25, 2020
Merged

rls: fix build #93849

merged 1 commit into from Jul 25, 2020

Conversation

symphorien
Copy link
Member

fix copied from rustfmt

Motivation for this change

Fixes #93834

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
rls: fix build
2885306 
fix copied from rustfmt
cole-h
cole-h requested changes Jul 25, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: As of rustc 1.45.0, these env vars are required to build rustfmt and rls -> As of rustc 1.45.0, these env vars are required to build rls

rls isn't directly related to rustfmt, so why care if this is necessary to build rustfmt, when a similar line is already present in its derivation? ;)

(I'd make this a code suggestion, but GitHub is broken in my Firefox for whatever reason, and I haven't gotten around to debugging it)

@symphorien
Copy link
Member Author

fixed

@Mic92 Mic92 merged commit b150f71 into NixOS:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h requested changes

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RLS fails to build on master
3 participants
@symphorien @cole-h @Mic92