nixos/tests/networking: fix macvlan tests #93893
Conversation
|
I think the command goes like this: |
I can't say I'm an expert either, but I noticed in the failing logs that it said there weren't any free addresses, which led me to try adding the range back in the config. |
nixos/tests/networking.nix
Outdated
| @@ -33,13 +33,15 @@ let | |||
| enable = true; | |||
| interfaces = map (n: "eth${toString n}") vlanIfs; | |||
| extraConfig = '' | |||
| authoritative; | |||
There was a problem hiding this comment.
Huh, I was pretty sure I tested it without the authoritative line and it didn't work. It does now though, so 🤷♀️.
There was a problem hiding this comment.
That pull was only merged 20 hours ago.
There was a problem hiding this comment.
Yeah, but I only started working on this ~4 hours ago using then-current master.
The range option still needs to be defined in dhcpd4 to be able to give out static IP addresses
chvp
force-pushed
the
fix-networking-macvlan
branch
from
e935a42
to
8eca34d
Compare
|
@GrahamcOfBorg test networking.scripted.macvlan |
|
I'm not sure dhcpd4 will like the overlap between static and dynamic leases. |
|
All the examples I found (e.g. https://wiki.archlinux.org/index.php/Dhcpd) have overlapping static and dynamic leases. |
|
Ah well, this works as long as the dynamic address hasn't been allocated to some other machine when the static lease gets introduced. So I wouldn't recommend such an overlap in practice, but it should work here. |
|
@GrahamcOfBorg test networking.scripted.macvlan |
Motivation for this change
The range option still needs to be defined in dhcpd4 to be able to give out static IP addresses.
Fixes #93704.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)