Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecraft: 2.1.15852 -> 2.1.16102 #93929

Merged
merged 1 commit into from Jul 27, 2020

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

The launcher shows a pop up asking to update. The update itself is minor according to the changelog.

Things done

Run the maintainer update script. Install and check functionality.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member Author

rebasing to help OfBorg

@bbjubjub2494
Copy link
Member Author

It turns out I cant do anything because OfBorg checks the merged PR rather than the tip. My bad, TIL.

@infinisil
Copy link
Member

Looking good!

@infinisil infinisil merged commit f168077 into NixOS:master Jul 27, 2020
@bbjubjub2494 bbjubjub2494 deleted the minecraft-launcher branch December 31, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants