New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue659 - Problems constraining to ends of Helix. #661
Conversation
Hm, looks like mimalloc causes all of our tests to fail. |
Did you respond to the wrong PR? |
Nope, I was looking into why tests fail on this PR. Turns out they just fail on all Linux builds now. |
I filed microsoft/mimalloc#279. |
Seems like they pushed a fix upstream, do you think you can check if their commit fixes the issue? |
How do I even test that? No sure how to update the link to a newer version of mimalloc (or other external libs) so that Travis will use it. |
|
@nabijaczleweli Thanks, but I'm still missing something. First, I can't reproduce the issue here, the tests pass. It would be cool to issue a PR using a newer mimalloc and let travis test it but I'm not sure how to update the external link itself. Locally I have folders full of code, not links with hashes. |
And those folders full of code are git repositories of their own (indeed, if you try to add a repository to a repository, git will yell at you to use a submodule instead), with the HEAD SHAs showing up if you diff them from the parent project: I pushed the commit to a branch here, too: https://github.com/nabijaczleweli/solvespace/tree/submodules-how-do-they-work, feel free to PR it or do whatever else you feel is prudent |
Thanks! I tried that here and then made a PR to see if it fixes the problem. |
Create a new copy type for faces that includes the translation aspect of helical extrusions. Also swap the end remappings when the shell is inside out - this was also affecting some Revolve extrusions.
Create a new copy type for faces that includes the translation aspect of helical extrusions. Also swap the end remappings when the shell is inside out - this was also affecting some Revolve extrusions.