Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] python: aiohue: 1.10.1 -> 2.1.0 #93898

Merged
merged 1 commit into from Jul 26, 2020
Merged

[20.03] python: aiohue: 1.10.1 -> 2.1.0 #93898

merged 1 commit into from Jul 26, 2020

Conversation

uvNikita
Copy link
Contributor

(cherry picked from commit 42abb50)

Motivation for this change

The old library version simply doesn't work with the new API.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt

This comment has been minimized.

Sign in to view
@uvNikita
Copy link
Contributor Author

This is a cherry picked commit for back-porting into 20.03, so I shouldn't add anything else here? I guess if we want to modify the package in any way we should rather do it in master?

@mweinelt
Copy link
Member

Yes, I noticed that too late and hence marked my previous comment as outdated.

@mweinelt
Copy link
Member

My problem with this backport is, that home-assistant 0.104.3, which is the latest version in 20.03, still pins aiohue to 1.10.1.

https://github.com/home-assistant/core/blob/0.104.3/homeassistant/components/hue/manifest.json#L6

Have you tested, whether this change makes it work?

@uvNikita
Copy link
Contributor Author

I'm new to the home-assistant, but basic discovery and light control seem to work.

That said, it seems like only initial discovery of the hue bridge doesn't work. After I added the bridge, I could revert back the aiohue library back.

@mweinelt
Copy link
Member

There does not seem to be any other user of the library and the were no API changes involved on the hass side, when the library was bumped there. So I don't see how it could get worse from here.

@mweinelt mweinelt merged commit 735df1a into NixOS:release-20.03 Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uvNikita @mweinelt @FRidh