Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lf: 14 -> 15 #93895

Merged
merged 1 commit into from Jul 26, 2020
Merged

lf: 14 -> 15 #93895

merged 1 commit into from Jul 26, 2020

Conversation

yoctocell
Copy link
Member

Motivation for this change

Update to newest release
https://github.com/gokcehan/lf/releases/tag/r15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from primeos and kalbasit July 26, 2020 09:21
danieldk
danieldk approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 93895 1

1 package built:
- lf

Binary works as expected.

BTW. not sure if this is worthwhile reporting upstream, but lf will segfault when /etc/passwd is not readable (e.g. in a sandbox):

$ wrapit `realpath results/lf/bin/lf`
2020/07/26 09:30:24 user: user: lookup userid 1000: no such file or directory
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x57ad2a]

goroutine 1 [running]:
main.init.3()
	/build/source/os.go:72 +0x7da

@danieldk danieldk merged commit 8404c35 into NixOS:master Jul 26, 2020
@primeos
Copy link
Member

primeos commented Jul 26, 2020 •
edited

@danieldk it's probably a very rare edge case but why not? Will you submit a report or should I take care of it?

From the code it looks like it would make sense to change this part. Especially the handling of err != nil (a few lines above) seems wrong (resulting in the segmentation fault). IMO it would be better to actually fallback to $HOME and $USER or just exit cleanly (we could also submit a PR).

@danieldk
Copy link
Contributor

danieldk commented Jul 26, 2020 •
edited

@danieldk it's probably a very rare edge case but why not? Will you submit a report or should I take care of it?

Turns out there already was an issue about that gokcehan/lf#191, so I added a comment to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@primeos primeos Awaiting requested review from primeos

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoctocell @primeos @danieldk