Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openzone: init at 1.2.9 #93917

Merged
merged 2 commits into from Jan 11, 2021
Merged

openzone: init at 1.2.9 #93917

merged 2 commits into from Jan 11, 2021

Conversation

zaninime
Copy link
Contributor

Motivation for this change

Fixes #93403. I'm currently using it on my desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zaninime
Copy link
Contributor Author

@laikq, mind giving a look again? Thanks.

@laikq
Copy link
Contributor

laikq commented Jul 28, 2020

From my perspective, it's looking good. I could install the cursor theme with nix-env, and changed it with lxappearance. Worked. But I think it would be a good idea to split this change into 2 commits, one for icon-slicer and one for openzone-cursors. (And I don't have merge/commit rights, so this PR needs another reviewer)

@zaninime
Copy link
Contributor Author

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 26, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 26, 2020
@zaninime
Copy link
Contributor Author

I'm splitting the change in two commits for the two packages I'm adding.

@zaninime zaninime requested a review from dtzWill October 26, 2020 21:34
@zaninime
Copy link
Contributor Author

@dtzWill mind having a look as well and merge if appropriate?

SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/data/themes/openzone/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/icon-slicer/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/openzone/default.nix Outdated Show resolved Hide resolved
@zaninime
Copy link
Contributor Author

@SuperSandro2000 could you please check again?

SuperSandro2000
SuperSandro2000 reviewed Nov 26, 2020
View reviewed changes
pkgs/tools/X11/icon-slicer/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/icon-slicer/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/icon-slicer/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93917 run on x86_64-linux 1

2 packages built:
  • icon-slicer
  • openzone-cursors

@zaninime zaninime force-pushed the openzone branch 2 times, most recently from eced473 to 546dde5 Compare January 6, 2021 13:34
@zaninime
Copy link
Contributor Author

zaninime commented Jan 6, 2021

@SuperSandro2000 sorry for the extra delay. I applied all the code suggestions you had and rebased. This should be now good to go.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 93917 run on x86_64-linux 1

2 packages built:
  • icon-slicer
  • openzone-cursors

SuperSandro2000
SuperSandro2000 requested changes Jan 7, 2021
View reviewed changes
pkgs/tools/X11/icon-slicer/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/icon-slicer/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 93917 run on x86_64-linux 1

2 packages built:
  • icon-slicer
  • openzone-cursors

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 10, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 93917 run on x86_64-linux 1

2 packages built:
  • icon-slicer
  • openzone-cursors

@SuperSandro2000 SuperSandro2000 merged commit c9234f3 into NixOS:master Jan 11, 2021
@zaninime zaninime deleted the openzone branch July 30, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laikq laikq laikq left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenZone cursor themes
3 participants
@zaninime @laikq @SuperSandro2000