Authserver cleanup phase 3 - the account table unfuckening #25135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks https://github.com/TrinityCore/aowow, in particular login using TC as auth. See https://github.com/TrinityCore/aowow/blob/master/includes/user.class.php#L286 . It would be nice if that tool (and other tools under the TC umbrella) would be updated before merging this PR |
|
@jackpoz we want some of the changes in this PR before updating external tools re-added |
Treeston
force-pushed
the
3.3.5-auth-stage3
branch
from
e7743fd
to
4be5b66
Compare
Treeston
changed the title
This was referenced Jul 26, 2020
Treeston
force-pushed
the
3.3.5-auth-stage3
branch
from
f460c0c
to
c909b0a
Compare
Shauren
requested changes
Jul 29, 2020
|
I would add https://github.com/TrinityCore/account-creator also to the list of apps that would be nice to fix before merging this |
- salt/verifier/sessionkey are now binary - old s/v/sha_pass_hash fields kept around for backwards compatibility - sha_pass_hash is only read if s/v have been manually changed - sha_pass_hash is still updated (for now), s/v are not - no longer use sha_pass_hash for anything else core-side (.account, SOAP, RA)
…definitely sure that this is a legacy tool)
Treeston
force-pushed
the
3.3.5-auth-stage3
branch
from
c50dabc
to
9b35dc0
Compare
Shauren
reviewed
Jul 31, 2020
…r are nullable for now.
…just in case some tool does silly things.
…s this should be at least 256 bits (>256 makes no sense for our 256-bit N)
masterking32
added a commit
to masterking32/WoWSimpleRegistration
that referenced
this pull request
Aug 3, 2020
Shauren
pushed a commit
that referenced
this pull request
Aug 3, 2020
- no longer use sha_pass_hash for anything else core-side (.account, SOAP, RA) - salt/verifier/session_key are now binary - old s/v/sha_pass_hash fields kept around for backwards compatibility - sha_pass_hash is still updated (for now), s/v are not - sha_pass_hash is only read if s/v have been manually changed - SRP6 b now uses the full 32 bytes of randomness (instead of randomly only using 19) (cherry picked from commit 3164b58)
masterking32
added a commit
to masterking32/WoWSimpleRegistration
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is part 3 of 5 in the deprecation process of
sha_pass_hash, as outlined in #25157.)Changes
saltandverifierare nowBINARY(32), fromVARCHAR(64)SessionKeyis nowBINARY(40), fromVARCHAR(80)Backwards compatibility
sha_pass_hashwill still be updated, and external tools can still set itsha_pass_hashwill only be read if backwards-compatibility fieldss/vwere changed by external tools