cmake: 3.17.3 -> 3.18.0 #93886
Merged
cmake: 3.17.3 -> 3.18.0 #93886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, |
jtojnar
requested changes
Jul 26, 2020
There was a problem hiding this comment.
- I did not see anything alarming in the changelog but someone more familiar with CMake should review it too.
- The patch needs to be reapplied correctly.
- The target branch needs to be changed to staging since this is a mass rebuild (see edit button at the top of this page).
r-burns
requested review from
adisbladis,
cdepillabout,
FRidh,
jonringer,
Lassulus,
Mic92 and
Profpatsch
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New CMake version 3.18 available
https://cmake.org/cmake/help/v3.18/release/3.18.html
Things done
Patches had some conflicts, but they seemed to be trivial to resolve. Did that via
git applyand merge on the cmake git itself - let me know if there's a more nixy way to do that.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)