Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/top-level: add x86_64-redox to release-cross.nix #93905

Merged
merged 1 commit into from Aug 3, 2020
Merged

pkgs/top-level: add x86_64-redox to release-cross.nix #93905

merged 1 commit into from Aug 3, 2020

Conversation

aaronjanse
Copy link
Member

Motivation for this change

Fixes #93663

Things done

I have no idea how to test this change. Once I do know, I'd be happy to add that info as a comment in release-cross.nix via either this PR or a new one.

Marked as a draft until I have reason to believe this PR won't break anything major :-)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
Copy link
Member

Ericson2314 commented Aug 2, 2020 •
edited

@aaronjanse Any reason why this is a draft? Looks good to me!

@Ericson2314
Copy link
Member

Also, I should adjust codowners so I'll get notifications for these things :)

@aaronjanse
Copy link
Member Author

Any reason why this is a draft?

Simply because I don't know how to test locally if it breaks anything. I'll make it a non-draft now :-)

@aaronjanse aaronjanse marked this pull request as ready for review August 3, 2020 02:36
@Ericson2314 Ericson2314 merged commit 7f0a9a4 into NixOS:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Redox to release-cross.nix
2 participants
@aaronjanse @Ericson2314