Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nixos-rebuild.sh: Add --path-to-built-config #93863

Conversation

xavierzwirtz
Copy link
Contributor

@xavierzwirtz xavierzwirtz commented Jul 25, 2020

Added --path-to-built-config option to nixos-rebuild.sh to allow for building the system config manually, and then switching to it.

Motivation for this change

I wanted to experiment with using nix build to build my system image, but did not have a way to pass in the built system to nixos-rebuild without it redoing the work of the build.

Things done

Added --path-to-built-config option to nixos-rebuild.sh. Does not build the system image when executing either boot or switch, instead uses the supplied path.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Added --path-to-built-config option to nixos-rebuild.sh to allow for
building the system config manually, and then switching to it.
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@xavierzwirtz
Copy link
Contributor Author

I no longer use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants