Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-rtmidi: add alsaLib and libjack2 deps #93915

Merged
merged 1 commit into from Jul 26, 2020
Merged

python-rtmidi: add alsaLib and libjack2 deps #93915

merged 1 commit into from Jul 26, 2020

Conversation

graham33
Copy link
Contributor

python-rtmidi includes the rtmidi C++ library as a submodule (which is
unfortunate since rtmidi is separately packaged in nixpkgs already) and wraps it
using Cython. Without these dependencies, python-rtmidi won't build support for
ALSA or jack into the compiled rtmidi, and will only have the 'dummy' API
available.

Motivation for this change

Allows access to MIDI ports via ALSA and jack.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@graham33
python-rtmidi: add alsaLib and libjack2 deps
2a5325d 
python-rtmidi includes the rtmidi C++ library as a submodule (which is
unfortunate since rtmidi is separately packaged in nixpkgs already) and wraps it
using Cython.  Without these dependencies, python-rtmidi won't build support for
ALSA or jack into the compiled rtmidi, and will only have the 'dummy' API
available.
@graham33
Copy link
Contributor Author

@mweinelt FYI

@ofborg ofborg bot requested a review from mweinelt July 26, 2020 14:05
@mweinelt
Copy link
Member

Yikes, sorry for the oversight.

@mweinelt mweinelt merged commit 6bf0672 into NixOS:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graham33 @mweinelt