Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.recommonmark: mark broken #93916

Merged
merged 1 commit into from Jul 26, 2020
Merged

pythonPackages.recommonmark: mark broken #93916

merged 1 commit into from Jul 26, 2020

Conversation

DieGoldeneEnte
Copy link
Contributor

@DieGoldeneEnte DieGoldeneEnte commented Jul 26, 2020 •
edited

recommonmark marked broken (rest of this text is outdated)

Motivation for this change

Adds sphinx2, because recommonmark doesn't support sphinx 3 (this fixes #93117).
To add sphinx2 the file pkgs/development/python-modules/sphinx/2.nix has been renamed to 1.nix, since it contains sphinx 1.8.5 (which still uses python2).

altair is also setup to use sphinx2, otherwise it fails because of multiple sphinx versions.

The second commit updates sphinx2 from 2.3.1 to 2.4.4.

All packages that failed to build did so for unrelated reason.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Jul 26, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not have more versions of Sphinx. A separate version for Python 2 and 3 is fine, but not versions for specific packages because we do not want conflicts.

@FRidh
Copy link
Member

FRidh commented Jul 26, 2020

Recommonmark should be considered broken until it can function with Sphinx 3.

@DieGoldeneEnte
recommonmark: marked broken
14078bd 
It doesn't work with sphinx 3.
@DieGoldeneEnte DieGoldeneEnte changed the title pythonPackages.sphinx: added sphinx2 for recommonmark pythonPackages.recommonmark: mark broken Jul 26, 2020
@FRidh FRidh merged commit 36a6903 into NixOS:master Jul 26, 2020
@FRidh
Copy link
Member

FRidh commented Jul 26, 2020

Thanks

@doronbehar
Copy link
Contributor

Hey, this PR seems to has caused every other ofborg evaluation to fail, see e.g: https://gist.github.com/GrahamcOfBorg/bd77c598a9c1efc81c68d35f23352e31 and #93932

@DieGoldeneEnte
Copy link
Contributor Author

DieGoldeneEnte commented Jul 26, 2020 •
edited

Any idea what the problem could be? It looks good to me and only tells me the package is broken if I try to build it (or anything depending on it).
This is the first package I marked broken, so I might have missed something?

@FRidh
Copy link
Member

FRidh commented Jul 26, 2020

hopefully fixed with c28df99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recommonmark doesn't build because of failing tests with sphinx 3
3 participants
@DieGoldeneEnte @FRidh @doronbehar