Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hikari: 2.0.4 -> 2.1.0 #93921

Closed
wants to merge 1 commit into from
Closed

hikari: 2.0.4 -> 2.1.0 #93921

wants to merge 1 commit into from

Conversation

wjlroe
Copy link
Contributor

@wjlroe wjlroe commented Jul 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jpotier July 26, 2020 14:56
@wjlroe
Copy link
Contributor Author

wjlroe commented Jul 26, 2020

I have built and run this update locally (I'm running it now as I type this) and it works as well as the current version in the master branch

jpotier
jpotier approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@jpotier jpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but someone else did. Change is minimal. LGTM

@jpotier
Copy link
Contributor

jpotier commented Jul 29, 2020

Hikari 2.1.1 is out btw!

@wjlroe
Copy link
Contributor Author

wjlroe commented Jul 30, 2020

Closed in favour of updated PR #94266

@wjlroe wjlroe closed this Jul 30, 2020
@wjlroe wjlroe deleted the hikari-2.1.0 branch July 31, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpotier jpotier jpotier approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjlroe @jpotier