Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38Packages.pandas: fix build on darwin #93889

Merged
merged 1 commit into from Jul 26, 2020
Merged

python38Packages.pandas: fix build on darwin #93889

merged 1 commit into from Jul 26, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 26, 2020

Motivation for this change

Fixes #93875
cc @nbren12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jul 26, 2020
@ofborg ofborg bot requested review from 7c6f434c and knedlsepp July 26, 2020 06:02
@marsam marsam merged commit 8aa8da2 into NixOS:master Jul 26, 2020
@marsam marsam deleted the fix-pandas-darwin branch July 26, 2020 21:33
@nbren12
Copy link
Contributor

nbren12 commented Jul 27, 2020

Thanks @marsam for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python38 pandas is broken on macosx
2 participants
@marsam @nbren12