dell/xps/13-9360: conflicting font fix #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 26, 2020
| # 4K screen, use bigger console font | ||
| # i18n.consoleFont deprecated and obsolete in >=20.03 | ||
| # hardware-configuration.nix generates console.font | ||
| i18n.consoleFont = lib.mkIf (lib.versionOlder (lib.versions.majorMinor lib.version) "20.03") (lib.mkDefault "latarcyrheb-sun32"); |
There was a problem hiding this comment.
In unstable this should instead enable our new hidpi module instead. This should not cause a conflict because nixos-generate-config does the same.
There was a problem hiding this comment.
Whats the new hidpi module?
Where is that? (im pretty new to nixos)
There was a problem hiding this comment.
...also it might be not required at all anymore because nixos-generate-config already adds it automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed setting console.font for >= 20.03
because the auto generated
hardware-configuration.nixnow sets:Which cause the following error when also importing
<nixos-hardware/dell/xps/13-9360>:Closes #177