libnifalcon: init at 1.1 #95355
libnifalcon: init at 1.1 #95355
Conversation
There was a problem hiding this comment.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package build on x86_64-linux
- executables tested on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- phases are respected
Possible improvements
Please see my comments
Comments
Builds fine & all binaries can be run, although I can't test them more, as I don't have this device.
| ''; | ||
|
|
||
| maintainers = with maintainers; [ wesliao ]; | ||
| }; |
There was a problem hiding this comment.
Please set meta.platforms, see nixpkgs manual for details:
Platforms should be set or the package will not get binary substitutes.
There was a problem hiding this comment.
platforms = platforms.all; should be fine, as the project states so itself.
| sha256 = "1gp2cf56rlnlw785vl90w6scpknajw2mdny26yqlx5yl277x9b9s"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake libusb1 doxygen pkgconfig expat ]; |
There was a problem hiding this comment.
Are these all needed as run-time dependencies?
Build-time dependencies should be declared as nativeBuildInputs
There was a problem hiding this comment.
at least pkg-config needs to move.
| longDescription = | ||
| ''libnifalcon is a development library for the NovInt Falcon, |
There was a problem hiding this comment.
Please move the '' up behind longDescription, so it looks like this:
longDescription = ''
libnifalcon is a development library for the NovInt Falcon,
[...]
'';
| outputs = [ "out" "dev" ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "http://qdot.github.com/libnifalcon/"; |
There was a problem hiding this comment.
Link does not seem to work.
| { stdenv, fetchFromGitHub, cmake, doxygen, libusb1, pkgconfig, expat }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "libnifalcon-1.1"; |
There was a problem hiding this comment.
| name = "libnifalcon-1.1"; | |
| pname = "libnifalcon"; | |
| version = "1.1"; |
| src = fetchFromGitHub { | ||
| owner = "libnifalcon"; | ||
| repo = "libnifalcon"; | ||
| rev = "c1546ec8d9a94b3be7d74f8ba9f1a121a0ebb0c2"; |
There was a problem hiding this comment.
| rev = "c1546ec8d9a94b3be7d74f8ba9f1a121a0ebb0c2"; | |
| rev = version; |
| @@ -8779,6 +8779,12 @@ | |||
| email = "kirill.wedens@gmail.com"; | |||
| name = "wedens"; | |||
| }; | |||
| wesliao = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add wesliao.
| sha256 = "1gp2cf56rlnlw785vl90w6scpknajw2mdny26yqlx5yl277x9b9s"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake libusb1 doxygen pkgconfig expat ]; |
There was a problem hiding this comment.
at least pkg-config needs to move.
|
Closing due to unresponsive author. Feel free to reopen the discussion. |
Motivation for this change
A library for development using the Novint Falcon haptic device.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)