Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timescale-prometheus: init at 0.1.0-beta.1 #95359

Merged
merged 1 commit into from Aug 13, 2020
Merged

timescale-prometheus: init at 0.1.0-beta.1 #95359

merged 1 commit into from Aug 13, 2020

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Aug 13, 2020

Motivation for this change

timescale-prometheus 0.1.0-beta.1 released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F requested a review from marsam August 13, 2020 17:32
@Lassulus
Copy link
Member 

warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/qjjgpyn3xxvb0g82lp6m87qswqiwds6z-timescale-prometheus-0.1.0-beta.1.drv' failed with exit code 1; last 10 log lines:
  === CONT  TestEntryNotFound
  --- PASS: TestEntryNotFound (0.00s)
  === CONT  TestBatch
  --- PASS: TestBatch (0.00s)
  --- PASS: TestCacheGetRandomly (0.63s)
  PASS
  ok        github.com/timescale/timescale-prometheus/pkg/clockcache        0.628s
  Error setting up container failed to create container: creating reaper failed: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
  FAIL        github.com/timescale/timescale-prometheus/pkg/internal/testhelpers      0.005s
  FAIL
cannot build derivation '/nix/store/sxiw04a92xvcdq09z9ndyhfs6q45jpgm-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/sxiw04a92xvcdq09z9ndyhfs6q45jpgm-env.drv' failed

@Kloenk
Copy link
Member

Kloenk commented Aug 13, 2020

I would like it if we can give the commit Hash into go build, without it this output is printed (commit hash missing)

{"caller":"main.go:158","level":"info","msg":"Version:0.1.0-beta.1; Commit Hash: ","ts":"2020-08-13T17:48:29.773Z"}

@0x4A6F 0x4A6F force-pushed the master-timescale-prometheus branch 2 times, most recently from f99eb66 to 293048f Compare August 13, 2020 18:09
@0x4A6F 0x4A6F force-pushed the master-timescale-prometheus branch 3 times, most recently from 336fd7a to 0dbd3c8 Compare August 13, 2020 18:23
@Kloenk
Copy link
Member

Kloenk commented Aug 13, 2020

I would like it if we can give the commit Hash into go build, without it this output is printed (commit hash missing)

{"caller":"main.go:158","level":"info","msg":"Version:0.1.0-beta.1; Commit Hash: ","ts":"2020-08-13T17:48:29.773Z"}

We are not able to implement it, and its not an error. So should be fine without it.

@Lassulus Lassulus merged commit d5f6cce into NixOS:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kloenk Kloenk Kloenk left review comments

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x4A6F @Lassulus @Kloenk