Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyro-ppl: remove due to prolonged breakage #95350

Closed
wants to merge 1 commit into from
Closed

python3Packages.pyro-ppl: remove due to prolonged breakage #95350

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 13, 2020 •
edited

Motivation for this change

Was marked broken in oct 2019

#95265

cc @teh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-95350/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages removed:
python3.7-pyro-ppl (†1.3.1) python3.8-pyro-ppl (†1.3.1)

Nothing changed
https://github.com/NixOS/nixpkgs/pull/95350
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-95350/shell.nix

@jonringer jonringer requested a review from FRidh as a code owner August 13, 2020 16:18
bhipple
bhipple reviewed Aug 15, 2020
View reviewed changes
pkgs/development/python-modules/pyro-ppl/default.nix
homepage = "http://pyro.ai";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ teh ];
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing looks extremely actively maintained (last commit 1 hour ago). @stites @drewrisinger either of you used it? Maybe it was just broken due to an old pytorch, and now just needs an uprev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be that it has a very large and fragile dependency graph, in which case, it would be hard to maintain in context on the nixpkgs python set

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using actively but we're not on master nixpkgs. Might indeed be easier to maintain out of core nixpkgs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh might have an opinion because he updated to the recent version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was part of a large update, and pyro-ppl is "just a leaf" package, so it wasn't looked at for regressions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhipple never used it.

@rmcgibbo
Copy link
Contributor

Is this still necessary? The package builds and works fine on current master.

@drewrisinger
Copy link
Contributor

@rmcgibbo ack, closing. Tested build locally, passes smoke test. Unbroken in #104269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh teh teh left review comments

@bhipple bhipple bhipple left review comments

@drewrisinger drewrisinger drewrisinger left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonringer @rmcgibbo @drewrisinger @teh @bhipple @ryantm