Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.zope_i18n: remove due to prolonged breakage #95351

Merged
merged 1 commit into from Sep 4, 2020
Merged

python3Packages.zope_i18n: remove due to prolonged breakage #95351

merged 1 commit into from Sep 4, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 13, 2020 •
edited

Motivation for this change

Was marked broken in oct 2019

#95265

cc @cillianderoiste

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 13, 2020 16:24
@jonringer
Copy link
Contributor Author

this has been open for 3 weeks, going to merge once ofborg succeeds

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@jonringer jonringer merged commit e3c26f8 into NixOS:master Sep 4, 2020
@jonringer jonringer deleted the remove-zope-i18n branch September 4, 2020 19:38
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-merge-policy-for-an-always-green-hydra/8889/23

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/misuse-of-commit-permissions/10071/43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @nixos-discourse @FRidh