Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: remove StandardOutput=syslog, StandardError=syslog lines #95353

Merged
merged 1 commit into from Aug 13, 2020
Merged

nixos: remove StandardOutput=syslog, StandardError=syslog lines #95353

merged 1 commit into from Aug 13, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 13, 2020

Since systemd 243, docs were already steering users towards using
journal:

systemd/systemd@eedaf7f

systemd 246 will go one step further, it shows warnings for these units
during bootup, and will automatically convert these occurences to
journal:

[ 6.955976] systemd[1]: /nix/store/hwyfgbwg804vmr92fxc1vkmqfq2k9s17-unit-display-manager.service/display-manager.service:27: Standard output type syslog is obsolete, automatically updating to journal. Please update│······················
your unit file, and consider removing the setting altogether.

So there's no point of keeping syslog here, and it's probably a better
idea to just not set it, due to:

This setting defaults to the value set with DefaultStandardOutput= in
systemd-system.conf(5), which defaults to journal.

Discovered during #94354.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos: remove StandardOutput=syslog, StandardError=syslog lines
962e15a 
Since systemd 243, docs were already steering users towards using
`journal`:

systemd/systemd@eedaf7f

systemd 246 will go one step further, it shows warnings for these units
during bootup, and will [automatically convert these occurences to
`journal`](systemd/systemd@f3dc6af):

> [    6.955976] systemd[1]: /nix/store/hwyfgbwg804vmr92fxc1vkmqfq2k9s17-unit-display-manager.service/display-manager.service:27: Standard output type syslog is obsolete, automatically updating to journal. Please update│······················
 your unit file, and consider removing the setting altogether.

So there's no point of keeping `syslog` here, and it's probably a better
idea to just not set it, due to:

> This setting defaults to the value set with DefaultStandardOutput= in
> systemd-system.conf(5), which defaults to journal.
@flokli flokli mentioned this pull request Aug 13, 2020
Merged
picnoir
picnoir approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with syslog and I was a bit worried this could break some syslog-based setups. I just had a quick look at how syslog is supposed to collect a systemd service output.

According to the journald.conf manpage, it looks like the current way to go is to enable the ForwardToSyslog option. This will make journald spinup a syslog socket to /run/systemd/journald/syslog. As a footnote: our rsyslog module will ingest this socket by default.

Overall, you want your syslog data to be first ingested by the journal. Removing these entries makes sense and is unlikely to break any existing setup.

LGTM

@flokli flokli merged commit f3ba51f into NixOS:master Aug 13, 2020
@flokli flokli deleted the systemd-output-journal branch August 13, 2020 19:45
@obadz obadz mentioned this pull request Oct 5, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @picnoir