Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.10 -> 0.11 #94857

Closed
wants to merge 1 commit into from
Closed

discord: 0.10 -> 0.11 #94857

wants to merge 1 commit into from

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Aug 7, 2020 •
edited

Motivation for this change

Discord 0.10 does not start any more as there is a newer version available.

Things done

Bumped to the current version 0.11.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds locally
  • Minimally tested all updates. Got segmentation faults, but that's probably because I'm testing on WSL vs NixOS, but version numbers showed correctly.

Minor issue: the following error showed for the discord-canary attribute when launching:

./result-2/bin/DiscordCanary: error while loading shared libraries: libdrm.so.2: cannot open shared object file: No such file or directory.

Not sure if the cause is WSL, or if the Nix derivation will need changed in future to reference an external library.

NOTE: this doesn't build properly with nix-review, so tested by checking out the PR & building.

@jonringer
Copy link
Contributor

discord 0.11 is already on master

Thanks for making the PR though :)

@jonringer jonringer closed this Aug 7, 2020
@jonringer
Copy link
Contributor

Was changed in ded6c3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phryneas @jonringer @drewrisinger