osu-lazer: 2020.801.0 -> 2020.806.0 #94833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgne2
changed the title
notgne2
force-pushed
the
osu-lazer-fix-and-update
branch
from
0daaf23
to
a3b810c
Compare
jonringer
reviewed
Aug 7, 2020
| - // should eventually be handled in a better way. | ||
| - VersionHash = $"{Version}-{RuntimeInfo.OS}".ComputeMD5Hash(); | ||
| - } | ||
| + VersionHash = "253aa3a3a356a71295bf5b018cd4fda1"; |
There was a problem hiding this comment.
does this need to be touched along with other updates?
There was a problem hiding this comment.
From what I've tested no, it may just be that the versions were "close enough", but I don't think the version gets sent alongside this, the only place it seems to be used is here https://github.com/ppy/osu/blob/80496d8d7f436eb1fee0a87d35c0b5ccde450b7c/osu.Game/Screens/Multi/Play/TimeshiftPlayer.cs#L61
jonringer
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bump version.
While testing, I also discovered that this build of osu-lazer was unable to play multiplayer, due to some unusual and presumably misinformed hash/tamper check of a game component (
osu.Game.dll), so I've made a patch to hardcode it to a hash from their appimage (the version itself appears to be irrelevant), though I can integrate the process of acquiring this hash into the Nix derivation if necessary.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)