Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packet-cli: 0.0.7 -> 0.0.8 #94847

Merged
merged 2 commits into from Aug 7, 2020
Merged

packet-cli: 0.0.7 -> 0.0.8 #94847

merged 2 commits into from Aug 7, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

packet-cli: update to latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne and kalbasit August 7, 2020 05:22
@colemickens
Copy link
Member Author

colemickens commented Aug 7, 2020 •
edited

I think this tool's binary is meant to be packet. In the interest of backward compatibility, I added another commit that symlinked packetto the existing packet-cli.

@Br1ght0ne
Copy link
Member

Thank you @colemickens for the help! Symlink is a good idea IMO. I'm merging.

@Br1ght0ne Br1ght0ne merged commit 3a3e61b into NixOS:master Aug 7, 2020
@colemickens colemickens deleted the packet-cli branch December 30, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @Br1ght0ne