Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackags.plaid-python: 4.0.0 -> 6.0.0 #94835

Merged
merged 1 commit into from Aug 8, 2020
Merged

pythonPackags.plaid-python: 4.0.0 -> 6.0.0 #94835

merged 1 commit into from Aug 8, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Aug 7, 2020

Tested end-to-end with my plaid python scripts.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
pythonPackags.plaid-python: 4.0.0 -> 6.0.0
6350ea2 
Tested end-to-end with my plaid python scripts.
drewrisinger
drewrisinger approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • builds via nix-review
https://github.com/NixOS/nixpkgs/pull/94835
3 packages built:
python27Packages.plaid-python python37Packages.plaid-python python38Packages.plaid-python

@bhipple
Copy link
Contributor Author

bhipple commented Aug 8, 2020

Thanks @drewrisinger !

@bhipple bhipple merged commit 82a8b3c into NixOS:master Aug 8, 2020
@bhipple bhipple deleted the u/plaid-python branch November 1, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @drewrisinger