Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtwebkit: 5.212-alpha-01-26-2018 -> 5.212.0-alpha4 #94825

Merged
merged 1 commit into from Aug 7, 2020
Merged

qtwebkit: 5.212-alpha-01-26-2018 -> 5.212.0-alpha4 #94825

merged 1 commit into from Aug 7, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 6, 2020

Motivation for this change

Fix qtwebkit build as mentioned in #94296

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp requested a review from ttuegel as a code owner August 6, 2020 22:30
@flokli
Copy link
Contributor

flokli commented Aug 6, 2020

This returns a 404 for me:

trying https://github.com/qtwebkit/qtwebkit/archive/qtwebkit-20.09.git.4fe5107376fM.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   150  100   150    0     0    672      0 --:--:-- --:--:-- --:--:--   672
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download source from any mirror
builder for '/nix/store/54dqiywlv490j37ygz8gl5wd6b3cmgbj-source.drv' failed with exit code 1

@flokli
Copy link
Contributor

flokli commented Aug 6, 2020

This is due to ${version} inside rev being stdenv.lib.version.

After removing the global with stdenv.lib;, I could get it to compile (and some application using it to run)

@bachp
Copy link
Member Author

bachp commented Aug 7, 2020

@flokli I think what is missing is the rec keyword. I will push a fix soon

@infinisil infinisil merged commit 9a452a6 into NixOS:master Aug 7, 2020
@bachp bachp deleted the qtwebkit-5.212.0-alpha4 branch August 8, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @flokli @infinisil