Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marble: switch from qtwebkit to qtwebengine #94826

Merged
merged 1 commit into from Aug 7, 2020
Merged

marble: switch from qtwebkit to qtwebengine #94826

merged 1 commit into from Aug 7, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 6, 2020

Motivation for this change

Switch marble from qtwebkit to the more modern qtwebengine.

#53079

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp requested a review from ttuegel as a code owner August 6, 2020 22:32
@ttuegel ttuegel merged commit 328d59f into NixOS:master Aug 7, 2020
@ttuegel
Copy link
Member

ttuegel commented Aug 7, 2020

Thanks!

@veprbl veprbl mentioned this pull request Aug 20, 2020
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @ttuegel