Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] openjdk: 8u222 -> 8u265 #94868

Merged
merged 3 commits into from Aug 10, 2020
Merged

[20.03] openjdk: 8u222 -> 8u265 #94868

merged 3 commits into from Aug 10, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Aug 7, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
✘ asbachb@nixos  ~/dev/src/nix/nixpkgs   backport/openjdk8  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 85, done.
remote: Counting objects: 100% (85/85), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 88 (delta 76), reused 78 (delta 75), pack-reused 3
Unpacking objects: 100% (88/88), 12.82 KiB | 397.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   588940d405d..066c604eec6  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-a3d104acfe7f3776779bfbdbb05ad4a035475303-dirty/nixpkgs 066c604eec6089e25aa5c4cc933decebdf8aa626
Preparing worktree (detached HEAD 066c604eec6)
Updating files: 100% (22333/22333), done.
HEAD is now at 066c604eec6 Merge pull request #94867 from Mic92/nixos-whitespace
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-a3d104acfe7f3776779bfbdbb05ad4a035475303-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

asbachb and others added 3 commits August 7, 2020 16:19
@asbachb
openjdk8: 8u222 -> 8u242
ec3bf7a 
(cherry picked from commit 36c53f7)
@asbachb
openjdk8: 8u222b10 -> 8u242b08
da0211c 
(cherry picked from commit b87e7d0)
@jerith666 @asbachb
openjdk8: 1.8.0_242 -> 1.8.0_265
a3d104a 
(cherry picked from commit 0afe6a2)
@asbachb asbachb changed the title [20.03] backport: openjdk 8u222 -> 8u265 [20.03] openjdk: 8u222 -> 8u265 Aug 7, 2020
@asbachb asbachb mentioned this pull request Aug 7, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from edwtjo and NeQuissimus August 7, 2020 14:41
@NeQuissimus NeQuissimus merged commit 366e210 into NixOS:release-20.03 Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asbachb @NeQuissimus @jerith666