Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runwayml: 0.10.20 -> 0.14.3 #94855

Merged
merged 1 commit into from Aug 22, 2020
Merged

runwayml: 0.10.20 -> 0.14.3 #94855

merged 1 commit into from Aug 22, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 7, 2020 •
edited

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

The previous and this version fails to start for me, so I can't test it. The error is

** (process:30837): ERROR **: 14:24:58.568: bind: g_dir_open: No such file or directory
[1]    30835 trace trap (core dumped)  result/bin/runwayml

Which is the same error I got for steam before #94442 switched steam to the new buildFHSUserEnvBubblewrap. So I believe this should be fixed once appimageTools are switched to that as well.

But anyways, as long as the update works for you that's fine. Do you maybe want to update the PR to 0.14.3 which has since been released? I can merge it when ready.

@prusnak
Copy link
Member Author

prusnak commented Aug 22, 2020

Updated the PR to 0.14.3 and yes, the update works for me.

@prusnak prusnak changed the title runwayml: 0.10.20 -> 0.14.0 runwayml: 0.10.20 -> 0.14.3 Aug 22, 2020
@infinisil infinisil merged commit ecaebb0 into NixOS:master Aug 22, 2020
@prusnak prusnak deleted the runwayml branch August 23, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @infinisil