Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] libvirtd: polkit integration, security fixes (#87576) #94861

Closed
wants to merge 2 commits into from
Closed

[20.03] libvirtd: polkit integration, security fixes (#87576) #94861

wants to merge 2 commits into from

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Aug 7, 2020 •
edited

Motivation for this change

Backporting #87576 since it hadn't been done yet.

Things done

I've built and tested my system configuration with this change.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and fpletz August 7, 2020 12:10
@jakobrs
Copy link
Contributor Author

jakobrs commented Aug 7, 2020

It seems that PR was never made.

@jakobrs jakobrs mentioned this pull request Aug 8, 2020
Merged
10 tasks
@jakobrs
Copy link
Contributor Author

jakobrs commented Aug 8, 2020

I think the reason the PR was never made might be that Polkit is already enabled by default. But I just opened #94926, which just adds an assertion.

@SuperSandro2000
Copy link
Member

Due to the number of PRs nixpkgs gets every month we didn't review and merge this on in time before 20.03 hit EOL. If you think this PR is still relevant please rebase it on master or 20.09 and leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobrs @SuperSandro2000 @offlinehacker