Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 68.10.0 -> 68.11.0, 78.1.0 -> 78.1.1 [High security fixes] #94863

Merged
merged 4 commits into from Aug 8, 2020
Merged

thunderbird, thunderbird-bin: 68.10.0 -> 68.11.0, 78.1.0 -> 78.1.1 [High security fixes] #94863

merged 4 commits into from Aug 8, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Aug 7, 2020

Motivation for this change

78.1.1:

  • Bug fixes and changes.

https://www.thunderbird.net/en-US/thunderbird/78.1.1/releasenotes/

68.11.0:

  • High security fixes
  • Other fix

https://www.thunderbird.net/en-US/thunderbird/68.11.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-35/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested thunderbird-78, thunderbird-bin-78, and thunderbird-bin. I'm building thunderbird.

@ofborg ofborg bot requested review from edolstra, nbp and lovesegfault August 7, 2020 12:41
@mweinelt
Copy link
Member

mweinelt commented Aug 7, 2020

Result of nixpkgs-review pr 94863 1

4 packages built:
- thunderbird
- thunderbird-78
- thunderbird-bin
- thunderbird-bin-78

@ShamrockLee ShamrockLee mentioned this pull request Aug 7, 2020
Merged
10 tasks
@ShamrockLee
Copy link
Contributor

Result of nixpkgs-review pr 94863:

4 packages built:
thunderbird thunderbird-78 thunderbird-bin thunderbird-bin-78

Takes at least two hours to build.
Tested thunderbird 68.11.0 on NixOS. LGTM

lovesegfault
lovesegfault approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mweinelt
Copy link
Member

mweinelt commented Aug 7, 2020 •
edited

And thunderdbird-78 tested on x86_64 for a few hours. LGTM.

@vcunat vcunat merged commit 58c66dd into NixOS:master Aug 8, 2020
vcunat added a commit that referenced this pull request Aug 9, 2020
@vcunat
thunderbird*: add 78 and update (to release-20.03)
e9bd19d 
This basically syncs the versions with master PR #94863.
@vcunat
Copy link
Member

vcunat commented Aug 9, 2020

I synchronized release-20.03 branch in e9bd19d – including filename changes to make also future backports easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taku0 @mweinelt @ShamrockLee @vcunat @lovesegfault @prusnak