New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tilt: 0.11.3 -> 0.17.0, move to buildGoModule #94827
Conversation
Result of 1 package failed to build:- tilt
|
}; | ||
|
||
goPackagePath = "github.com/windmilleng/tilt"; | ||
vendorSha256 = "18iiy5fv2jk07k8lfj6h60ldkm8i2zkhz61pf1ynw30jvh1yk93r"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add deleteVendor=true
as per comment 🤔
This will make buildGoModule
fetch dependencies inside go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was hoping this would work fine on other machines! It seems deleteVendor
is only needed when building the first time after moving from buildGoPackage
. It's not the most ergonomic since it pulls the dependencies every build, hopefully the cache speeds this up though.
nixpkgs-review pr 94827
seems to work for me after adding deleteVendor = true
, how's it looking on your machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It builds and runs fine now 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to build without deleteVendor
using just vendorSha256 = null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zowoq, either will work, the difference is where dependencies are sourced from. When vendorSha256 = null
the vendor folder supplied with the source is used, as opposed to deletedVendor = true
where dependencies will be fetched via go.mod
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteVendor
should only be used if the deps are incomplete/broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for clearing that up @zowoq, just pushed the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on NixOS ✔️
Thank you for your contribution 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove deleteVendor
and use vendorSha256 = null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally on darwin. aarch64 failure is a CI issue, it was building previously.
Motivation for this change
Application version bump with move to their new repo and little changes to get the build working again on latest updates.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)