Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wg-bond: init at 0.2.0 #94864

Merged
merged 1 commit into from Aug 8, 2020
Merged

wg-bond: init at 0.2.0 #94864

merged 1 commit into from Aug 8, 2020

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Aug 7, 2020

Motivation for this change

Packaged wg-bond — easy configuration manager for Wireguard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cab404
Copy link
Member Author

cab404 commented Aug 8, 2020

@GrahamcOfBorg build wg-bond

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/wg-bond-wireguard-configuration-manager-with-nix-and-nixops-support/8080/2

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/252

bhipple
bhipple requested changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just needs a license fix and small touchups.

pkgs/applications/networking/wg-bond/default.nix Show resolved Hide resolved
pkgs/applications/networking/wg-bond/default.nix Show resolved Hide resolved
pkgs/applications/networking/wg-bond/default.nix Outdated Show resolved Hide resolved
@cab404 cab404 requested a review from bhipple August 8, 2020 17:39
@cab404 @bhipple
wg-bond: init at 0.2.0
d9f98bb 
Co-authored-by: Benjamin Hipple <bhipple@protonmail.com>
@bhipple
Copy link
Contributor

bhipple commented Aug 8, 2020

Result of nixpkgs-review pr 94864 1

8 packages marked as broken and skipped:
- clang-sierraHack-stdenv
- crossLibcStdenv
- linuxPackages_4_4.sysdig
- linuxPackages_4_9.sysdig
- linuxPackages_hardkernel_4_14.sysdig
- linuxPackages_hardkernel_4_14.v4l2loopback
- linuxPackages_hardkernel_4_14.vhba
- steam-run-native
1 package built:
- wg-bond

@bhipple bhipple merged commit a221607 into NixOS:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cab404 @nixos-discourse @bhipple @jtojnar