Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jackett: 0.16.175 -> 0.16.998, switch to Mono, adding Darwin support #94839

Merged
merged 1 commit into from Aug 26, 2020
Merged

jackett: 0.16.175 -> 0.16.998, switch to Mono, adding Darwin support #94839

merged 1 commit into from Aug 26, 2020

Conversation

purcell
Copy link
Member

@purcell purcell commented Aug 7, 2020 •
edited

Motivation for this change
  • Updates version to avoid "your version is very old" warnings
  • Switches to Mono, which adds Darwin support while avoiding switching src URL according to platform

I had filed #94777 but will close that in favour of this, which I believe is a better approach: switching to Mono brings this into line with how nixpkgs treats similar programs like Sonarr and Radarr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@purcell purcell mentioned this pull request Aug 7, 2020
Closed
10 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Aug 7, 2020
@ofborg ofborg bot requested review from edwtjo and nyanloutre August 7, 2020 03:45
@purcell purcell changed the title jackett: 0.16.175 -> 0.16.962, switch to Mono, adding Darwin support jackett: 0.16.175 -> 0.16.998, switch to Mono, adding Darwin support Aug 16, 2020
@purcell
Copy link
Member Author

purcell commented Aug 16, 2020 •
edited

Bumped to even newer version in the meantime. One consequence of the Mono change is that Jackett appears to display a banner message at first run suggesting the use of a self-contained binary instead, in the interest of performance. This message persists only until settings have been applied and saved. I think that message is probably misguided, and would personally consider suppressing it.

@purcell
Copy link
Member Author

purcell commented Aug 25, 2020

Ping @marsam. :-)

@marsam marsam merged commit 884d15a into NixOS:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purcell @marsam