Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dash*: bump #94851

Merged
merged 4 commits into from Aug 9, 2020
Merged

python3Packages.dash*: bump #94851

merged 4 commits into from Aug 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 7, 2020 •
edited

Motivation for this change

closes #93885

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 7, 2020 07:24
@jonringer
Copy link
Contributor Author

python2 failure is from cryptography==3

https://github.com/NixOS/nixpkgs/pull/94851
1 package failed to build:
python27Packages.dash

11 packages built:
python27Packages.dash-core-components python27Packages.dash-renderer python27Packages.dash-table python37Packages.dash python37Packages.dash-core-components python37Packages.dash-renderer python37Packages.dash-table python38Packages.dash python38Packages.dash-core-components python38Packages.dash-renderer python38Packages.dash-table

@ofborg ofborg bot requested a review from antoinerg August 7, 2020 07:41
@FRidh
Copy link
Member

FRidh commented Aug 7, 2020

You could add the reverse dependencies to passthru.tests. That way r-ryantm and ofborg will fail.

@jonringer
Copy link
Contributor Author

I'm not the original maintainer, just trying to get PRs in before branch off

@jonringer
Copy link
Contributor Author

the tests can be done by the maintainer

@jonringer jonringer merged commit 5ee0817 into NixOS:master Aug 9, 2020
@jonringer jonringer deleted the bump-dash branch August 9, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@antoinerg antoinerg Awaiting requested review from antoinerg

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh